Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Workaround crash in WebContentsNSViewBridge::SetParentNSView
It has been observed that we are hitting the CHECK(parent_ns_view) in WebContentsNSViewBridge::SetParentNSView. Partially revert r625255, the culprit patch, by moving the functionality of WebContentsNSViewBridge::SetParentNSView in to the caller, NativeViewHostMac::AttachNativeView. This is not a reasonable long-term solution, but is the most reasonable merge candidate. Follow-on patches will move the CHECK up into NativeViewHostMac::AttachNativeView to see exactly why this is happening. Bug: 933679 Change-Id: I08b19f3123bbe96c49376a41f28a879a855bee62 Reviewed-on: https://chromium-review.googlesource.com/c/1487888 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635705}
- Loading branch information