-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[iOS][MF] Disconnect the mediator on |stop|.
Now the mediator stops observing objects when the incognito BVC is destroyed. Waiting for dealloc was causing a race condition with the autorelease pool, and some times a DCHECK will be hit. A minor strong block reference is also fixed in this CL. Bug: 934628, 939727 Change-Id: Ic65a7297eabf7ffad19119832a11125698215ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515572 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639885}(cherry picked from commit 5cb6233cc8e90faf1e47b6fd1201a04c80206430) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520675 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#84} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
- Loading branch information
Javier Ernesto Flores Robles
committed
Mar 13, 2019
1 parent
79cb489
commit f45c768
Showing
4 changed files
with
81 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters