Extern string #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do these warnings matter? : http://buildbot-master.node-webkit.org:8010/builders/win64_master/builds/66/steps/ninja_release/logs/stdio |
|
It shouldn't be an issue. There are similar warnings from original code (see last few warnings). |
rogerwang
pushed a commit
that referenced
this pull request
Aug 30, 2016
Original commit message:
Version 5.1.281.65 (cherry-pick)
Merged 85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba
Fix observable array access when formatting stack trace.
BUG=chromium:617527
LOG=N
R=hablich@chromium.org
Review URL: https://codereview.chromium.org/2051383002 .
Cr-Commit-Position: refs/branch-heads/5.1@{#76}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}
PR-URL: nodejs/node#8078
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
GnorTech
pushed a commit
that referenced
this pull request
Feb 1, 2017
Original commit message: Merged: [heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. Revision: a814b8aeaf2b56635054c96435972dce90576f62 BUG=chromium:666046 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Review URL: https://codereview.chromium.org/2549803002 . Cr-Commit-Position: refs/branch-heads/5.5@{#60} Cr-Branched-From: 3cbd5838bd8376103daa45d69dade929ee4e0092-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0ce2c9af0528837d8309625118d4096553b-refs/heads/master@{#40015} PR-URL: nodejs/node#10733 Reviewed-By: Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
rogerwang
pushed a commit
that referenced
this pull request
May 30, 2017
Original commit message:
[PATCH] Merged: Make Object::GetOwnPropertyDescriptor() take a Name, not a String.
Revision: b5e610c19208ef854755eec67011ca7aff008bf4
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=vogelheim@chromium.org
Bug:
Change-Id: I396b559b28aab6afa138db747711e50cd0da3da7
Reviewed-on: https://chromium-review.googlesource.com/513927
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.0@{#5}
Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{#45439}
PR-URL: nodejs/node#13217
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
rogerwang
pushed a commit
that referenced
this pull request
Oct 16, 2017
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: nodejs/node#15393
PR-URL: nodejs/node#15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
rogerwang
pushed a commit
that referenced
this pull request
Jan 11, 2018
Remove a pointless adapter frame by fixing up the function's formal
parameter count. Before:
frame #0: 0x000033257ea446d5 onParserExecute(...)
frame #1: 0x000033257ea3b93f <adaptor>
frame #2: 0x000033257ea41959 <internal>
frame #3: 0x000033257e9840ff <entry>
After:
frame #0: 0x00000956287446d5 onParserExecute(...)
frame #1: 0x0000095628741959 <internal>
frame #2: 0x00000956286840ff <entry>
PR-URL: nodejs/node#17693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
rogerwang
pushed a commit
that referenced
this pull request
Oct 12, 2018
Reverting this enables us to provide slower, but longer-lasting
replacements for the deprecated APIs.
Original commit message:
Put back deleted V8_DEPRECATE_SOON methods
This partially reverts
https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
which deleted many V8_DEPRECATE_SOON methods rather than moving them to
V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
Note V8_DEPRECATED that were deleted in the same CL stay deleted.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: v8:7786, v8:8240
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I00330036d957f98dab403465b25e30d8382aac22
Reviewed-on: https://chromium-review.googlesource.com/1251422
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#49}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
Refs: v8/v8@9136dd8
Refs: nodejs/node#23122
PR-URL: nodejs/node#23158
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rogerwang
pushed a commit
that referenced
this pull request
Oct 18, 2018
Reverting this enables us to provide slower, but longer-lasting
replacements for the deprecated APIs.
Original commit message:
Put back deleted V8_DEPRECATE_SOON methods
This partially reverts
https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
which deleted many V8_DEPRECATE_SOON methods rather than moving them to
V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
Note V8_DEPRECATED that were deleted in the same CL stay deleted.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: v8:7786, v8:8240
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I00330036d957f98dab403465b25e30d8382aac22
Reviewed-on: https://chromium-review.googlesource.com/1251422
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#49}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
Refs: v8/v8@9136dd8
Refs: nodejs/node#23122
PR-URL: nodejs/node#23158
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed nwjs/nw.js#2439