Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor install script #114

Merged
merged 38 commits into from
Oct 7, 2023
Merged

Refactor install script #114

merged 38 commits into from
Oct 7, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Oct 2, 2023 •
edited

Closes: #109
Closes: #93
Closes: #77
Closes: #74
Closes: #26

Description

  • Migrate from download to node:https for handling downloads
  • Migrate from decompress to compressing to handle decompression
  • Migrate from rimraf to node:fs's rm -rf function call.
  • Migrate from file-exists to node:fs's existsSync
  • Migrate from progress to cli-progress

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review October 2, 2023 05:19
@ayushmanchhabra ayushmanchhabra marked this pull request as draft October 3, 2023 20:07
ayushmanchhabra
ayushmanchhabra commented Oct 3, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
ayushmanchhabra
ayushmanchhabra commented Oct 3, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review October 3, 2023 21:32
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 5, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
ayushmanchhabra and others added 6 commits October 5, 2023 19:32
@ayushmanchhabra @TheJaredWilcurt
refactor: use optional chaining for prerelease check
53e31b0 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
fix: exit on incompatible version/(platform/arch)
bf92233 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
chore: remove additional console.log function
c8b4cab 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
refactor: use Array.prototype.join instead of $ operator
ed681cd 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra
refactor: use Array.prototype.join instead of $ operator
72ae57a
@ayushmanchhabra
chore: revert out of scope change
67d2e39
@ayushmanchhabra ayushmanchhabra changed the title refactor: install script Refactor install script Oct 6, 2023
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 6, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 6, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 6, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
@TheJaredWilcurt
Copy link
Member

Added some more comments, did not run locally.

ayushmanchhabra and others added 8 commits October 6, 2023 20:29
@ayushmanchhabra @TheJaredWilcurt
refactor: use String.prototype.endsWith
1f55f3f 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
refactor: use String.prototype.endsWith
0e9505c 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
refactor: use ! operator
93b7bbd 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
docs: indent JSDoc comments
dcae229 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
refactor: use String.prototype.endsWith
20a0f22 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
refactor: use String.prototype.endsWith
7c0213f 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra @TheJaredWilcurt
fix: destructure and append prelease array to versionString
b9a6794 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@ayushmanchhabra
refactor: decompression calls
bb2178d
TheJaredWilcurt
TheJaredWilcurt reviewed Oct 7, 2023
View reviewed changes
lib/install.mjs Outdated Show resolved Hide resolved
@ayushmanchhabra @TheJaredWilcurt
docs: improve function description
f033872 
Co-authored-by: The Jared Wilcurt <TheJaredWilcurt@users.noreply.github.com>
@TheJaredWilcurt TheJaredWilcurt merged commit 86b52bc into nwjs:master Oct 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJaredWilcurt TheJaredWilcurt Awaiting requested review from TheJaredWilcurt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ayushmanchhabra @TheJaredWilcurt