Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(findpath): detect ChromeDriver path #115

Merged
merged 12 commits into from Oct 24, 2023
Merged

feat(findpath): detect ChromeDriver path #115

merged 12 commits into from Oct 24, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Oct 16, 2023

Fixes: #23

Description

  • Refactor findpath function.
  • Detect ChromeDriver path if it exists.

@ayushmanchhabra ayushmanchhabra changed the title refactor: findpath function feat(findpath): detect ChromeDriver Oct 16, 2023
@ayushmanchhabra ayushmanchhabra changed the title feat(findpath): detect ChromeDriver feat(findpath): detect ChromeDriver path Oct 16, 2023
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review October 16, 2023 15:59
lib/findpath.mjs Outdated Show resolved Hide resolved
@TheJaredWilcurt TheJaredWilcurt merged commit fc3c0ef into nwjs:master Oct 24, 2023
1 check passed
@ayushmanchhabra ayushmanchhabra deleted the refactor/findpath branch October 24, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command to install chromedriver
2 participants