Skip to content

Commit

Permalink
Fix 984: delete shell obj asap in force close case
Browse files Browse the repository at this point in the history
  • Loading branch information
rogerwang committed Aug 21, 2013
1 parent 4cddc29 commit b67a7d8
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/api/app/app.cc
Expand Up @@ -137,6 +137,16 @@ void App::CloseAllWindows(bool force) {
windows[i]->window()->Close();
}
}
if (force) {
// in a special force close case, since we're going to exit the
// main loop soon, we should delete the shell object asap so the
// render widget can be closed on the renderer side
windows = Shell::windows();
for (size_t i = 0; i < windows.size(); ++i) {
if (!windows[i]->is_devtools())
delete windows[i];
}
}
}

// static
Expand Down

0 comments on commit b67a7d8

Please sign in to comment.