Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"locales" directory creation #2244

Closed
suckura opened this issue Aug 25, 2014 · 11 comments
Closed

"locales" directory creation #2244

suckura opened this issue Aug 25, 2014 · 11 comments
Labels

Comments

@suckura
Copy link

suckura commented Aug 25, 2014

After deletion of the "locales" directory NW silently create it again but newer fills it with some content. Is there any sense to have empty "locales" directory? If no, maybe just not create it if no exist.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nadimkobeissi
Copy link

👍, what's the reasoning behind this directory?

@micc83
Copy link

micc83 commented Nov 23, 2014

Same question. What is it the purpose of this folder?

@skibulk
Copy link

skibulk commented May 27, 2015

+1 can this be fixed?

1 similar comment
@ghost
Copy link

ghost commented Jan 8, 2016

+1 can this be fixed?

@Skhmt
Copy link

Skhmt commented Jan 26, 2016

+1 please fix

@baconbrad
Copy link

If you are using 0.12.X you can perform a workaround. To do this delete the locales directory completely. Then add this code to run when your app runs. This isn't usable on 0.13.0 because the locales directory is required by nw.js.

var fs = require('fs');
var path = require("path").dirname(process.execPath);
fs.rmdir(path + '/locales');

@stale
Copy link

stale bot commented Nov 6, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Nov 6, 2017
@Christywl
Copy link
Contributor

locales folder is required by nwjs now, I thinks this issue can be closed. @rogerwang

@skylarmt
Copy link

skylarmt commented Jan 1, 2018

The locales folder uses over 30MB of space, does NW.js really need all the different language files? Is there any actual user-visible text that depends on this data, or is it safe to only include en_US or something?

@djcanard
Copy link

Is there clean a way to exclude or include only some locales?
Is it safe to include only some locales manually?

@rogerwang
Copy link
Member

You can remove languages files that are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants