Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: NWJS not replacing the upper left hand icon with jpg file #3317

Open
jyapayne opened this issue Mar 30, 2015 · 5 comments
Open

Bug: NWJS not replacing the upper left hand icon with jpg file #3317

jyapayne opened this issue Mar 30, 2015 · 5 comments
Assignees

Comments

@jyapayne
Copy link

When using a jpg file for the window icon in the package.json, the upper left hand icon in Windows 7 & 8 is not replaced. I'm not sure if it's just with large jpg files, but the one that is being used is 1024x1024. I tried converting the file to png and the upper left hand icon was as expected. This happens with the latest version of nwjs and node webkit.

See here for more info, including the package.json and original icon that was used: nwutils/Web2Executable#7 (comment)

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jerone
Copy link

jerone commented Mar 30, 2015

I'm not sure if it's just with large jpg files, but the one that is being used is 1024x1024. I tried converting the file to png and the upper left hand icon was as expected.

I resized the big image to a 124x124 pixel image and still didn't work.
I also tried an 124x124 .png and that did work.
Looks like an .jpg only issue.

@baconbrad
Copy link

I don't think this is a bug and it is by design since jpg lacks transparency and is overall a terrible format technically for icons. As far as size goes, why would you need a 1024x1024 icon? Seems like a big waste of resources for something that will never render remotely close to that large.

@jyapayne
Copy link
Author

You could argue that it's not really a bug, and I could agree with you, since I agree that jpg is a terrible format. However, it should be specified somewhere that jpg's won't be placed in the upper left hand corner properly and that png's are MUCH preferred.

@jerone
Copy link

jerone commented Apr 10, 2015

The .jpg image I used, regardless the size, was a square image. So there's no need for transparency then.

Just note that favicons allow .jpg images too.

@baconface commented on 10 apr. 2015 07:16 CEST:

... As far as size goes, why would you need a 1024x1024 icon? ...

The situation required a big image. As state in my comment above #3317 (comment), I resized the image with same results. So it wasn't the size that was giving issues.

@Christywl
Copy link
Contributor

I try the icon mentioned in the issue, it doesn't work. And resize it to 128 x 128, it also doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants