Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Tray in background context #4862

Closed
RohitSharma27 opened this issue May 18, 2016 · 2 comments
Closed

Error in Tray in background context #4862

RohitSharma27 opened this issue May 18, 2016 · 2 comments
Assignees
@ghostoy
Milestone
0.14.x

Comments

@RohitSharma27
Copy link

Mac OS X El Capitan
NW v0.14.5 - SDK build
Hi,
There is an error getting logged in Background page's console, it says

extensions::nw.MenuItem:30 TypeError: item.click is not a function

Please download the package.nw from here
If I understand this page correct, then Tray shouldn't capture right click. But, the tray menu is responding to the 'Right click' as well.
Thanks.
@rogerwang rogerwang added this to the 0.14.x milestone May 18, 2016
@ghostoy
Copy link
Member

ghostoy commented May 19, 2016 •
edited
Loading

@RohitSharma27 First the error on console, it's just a line of log and doesn't have other side effects. I will remove that log later, since click is optional property for nw.MenuItem.
I will check with the click event on nw.Tray later today.

@RohitSharma27
Copy link
Author

RohitSharma27 commented May 19, 2016 •
edited
Loading

Yeah, the sample is running just fine. I thought, I should let you guys know. Cheers.

ghostoy pushed a commit to ghostoy/nw.js that referenced this issue May 23, 2016
not display errors if menuitem don't have click property
a846aaa 
`click` property is documented as optional. It should not be an
error if `click` doesn't exist.

fixed nwjs#4862
@ghostoy ghostoy mentioned this issue May 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghostoy ghostoy

Labels
None yet
Projects
None yet
Milestone
0.14.x
Development

No branches or pull requests
3 participants
@rogerwang @ghostoy @RohitSharma27