Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.14.5 sdk]inject_js_start not work #4877

Closed
lin-chao opened this issue May 23, 2016 · 9 comments
Closed

[0.14.5 sdk]inject_js_start not work #4877

lin-chao opened this issue May 23, 2016 · 9 comments
Assignees
@rogerwang
Milestone
0.14.x

Comments

@lin-chao
Copy link

version: 0.14.5
os: Windows

test code:

// package.json
{
  "main": "http://www.qq.com",
  "inject_js_start": "demo.js",
  "name": "menu demo",
  "window": {
    "width": 700,
    "height": 700
  }
}

// demo.js
alert('hello inject_js_start')

0.14.5 inject_js_start not work. can not alert "hello inject_js_star"
@rogerwang rogerwang added this to the 0.14.x milestone May 23, 2016
@rogerwang rogerwang self-assigned this May 23, 2016
@rogerwang
Copy link
Member

This should be a bug with remote page like #4656 , will fix it soon.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@rogerwang
Copy link
Member

http://dl.nwjs.io/live-build/05-24-2016/nw14-9b5c851-c26c469-2a9e6e1-5a26102

@lin-chao
Copy link
Author

@rogerwang

this version inject_js_start do not run in webview.

@rogerwang
Copy link
Member

Is it a regression? or a new issue you just found?

@rogerwang rogerwang reopened this May 24, 2016
@lin-chao
Copy link
Author

0.14.3 and versions before, inject_js_start can work in webview

was it a same bug?

@rogerwang
Copy link
Member

It's not the same bug. I'll fix webview and give updates here.

@rogerwang
Copy link
Member

This is fixed in git. Please try again with http://dl.nwjs.io/live-build/05-25-2016/nw14-edbe826-7183136-2a9e6e1-5a26102

@lin-chao
Copy link
Author

inject_js_start can run in webview.

thank you~

rogerwang added a commit that referenced this issue Jun 13, 2016
@rogerwang
Breaking nw_content: sync with later changes
8f8a160 
Don't migrate the data if new version is there
support data migration for custom domain app
Fix #4877: inject_js_start in remote pages
GnorTech pushed a commit that referenced this issue Jul 15, 2016
@rogerwang
Breaking nw_content: sync with later changes
5d92523 
Don't migrate the data if new version is there
support data migration for custom domain app
Fix #4877: inject_js_start in remote pages
rogerwang added a commit that referenced this issue Jul 21, 2016
@rogerwang
Breaking nw_content: sync with later changes
d963b2c 
Don't migrate the data if new version is there
support data migration for custom domain app
Fix #4877: inject_js_start in remote pages
rogerwang added a commit that referenced this issue Jul 27, 2016
@rogerwang
Breaking nw_content: sync with later changes
2cd78d6 
Don't migrate the data if new version is there
support data migration for custom domain app
Fix #4877: inject_js_start in remote pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
0.14.x
Development

No branches or pull requests
2 participants
@rogerwang @lin-chao