Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically handling proxy credentials in gui.App.setProxyConfig #4966

Closed
kevwilso opened this issue Jun 10, 2016 · 18 comments
Closed

Programmatically handling proxy credentials in gui.App.setProxyConfig #4966

kevwilso opened this issue Jun 10, 2016 · 18 comments
Labels

Comments

@kevwilso
Copy link

Hi All ( and @rogerwang ),

Our product currently utilizes 0.12.3 and is moving to 0.14.*. The product supports proxy scenarios and allows a customer to configure a proxy and internally we utilize gui.App.setProxyConfig to set it up.

One missing feature is a way to include the credentials needed for the Proxy in scenarios where proxy authentication is used. Currently a pop-up occurs and the user has to enter this every time they launch the application. Is there any way to avoid this pop-up and send the credentials via the setProxyConfig??

If not, I would like to request that as a feature. It would be of major help.

Thanks,

Kevin W.

@kevwilso kevwilso changed the title Programmatically handling proxy config credentials in gui.App.setProxyConfig Programmatically handling proxy credentials in gui.App.setProxyConfig Jun 10, 2016
@rogerwang
Copy link
Member

Will see this. Thanks

@rogerwang rogerwang self-assigned this Jun 11, 2016
@kevwilso
Copy link
Author

Thanks Roger. Let me know if you need any further information.

@kevwilso
Copy link
Author

Roger,

Quick question. What release do you think the solution will appear in? If you haven't narrowed it down no worries; just trying to do some planning on my side.

Thanks,

Kevin W.

@rogerwang
Copy link
Member

Will try to fix it in the next release. Thanks.

On Thu, Jun 23, 2016, 9:47 PM Kevin Wilson notifications@github.com wrote:

Roger,

Quick question. What release do you think the solution will appear in? If
you haven't narrowed it down no worries; just trying to do some planning on
my side.

Thanks,

Kevin W.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#4966 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAKGGfuk9nLUcFyNOdwHEle2Y8RXBThEks5qOo59gaJpZM4IzSyl
.

@rogerwang
Copy link
Member

Unfortunately the proxy config in Chromium internal doesn't support username/password, but you can workaround this by using the webrequest API: https://developer.chrome.com/extensions/webRequest#event-onAuthRequired

I'll also see to provide an API for the password manager in Chromium so you can save the username and password for users.

@rogerwang
Copy link
Member

I just enabled password saving for the auth dialog in git. It will be available in the next nightly build. Hopefully this will make life easier for your users.

@kevwilso
Copy link
Author

kevwilso commented Jul 11, 2016

Thanks Roger. When the username password is saved, it encrypted and is it save across sessions or is it clear on application restart.

@rogerwang rogerwang assigned sunlin-link and unassigned rogerwang Nov 17, 2016
@fujunwei
Copy link
Contributor

I am interested in trying this out, please assign it to me, thanks.

@fujunwei fujunwei assigned fujunwei and unassigned sunlin-link Nov 30, 2016
@fujunwei
Copy link
Contributor

fujunwei commented Dec 6, 2016

@rogerwang It can work with webRequest::onAuthRequired, Do you mean we need expose an api to developer like http://electron.atom.io/docs/api/app/#event-login?

@rogerwang
Copy link
Member

@fujunwei is that very different with webRequest::onAuthRequired?

And can reporter's need be fulfilled by webRequest::onAuthRequired?

@fujunwei
Copy link
Contributor

fujunwei commented Dec 6, 2016

@kevwilso Does webRequest::onAuthRequired satisfy your requirement?

@kevwilso
Copy link
Author

kevwilso commented Dec 6, 2016

Hi Roger/Fujunwei,

The webRequest::onAuthRequired is a satisfactory workaround. Note though the better solution would be to be able to gui.App.setProxyConfig. However, I understand current limitations there (re: chromium).

Thanks,

kevwilso

@fujunwei
Copy link
Contributor

fujunwei commented Dec 7, 2016

Thanks @kevwilso . @rogerwang Do we need to expose an API in nw.App based on webRequest extension?

@rogerwang
Copy link
Member

@fujunwei webRequest is already a supported API, I don't think we need to wrap it.

Maybe supporting username/password in nw.App.setProxyConfig with saving the password with password manager( components/password_manager) is a good choice. Another option is to wait for Chromium upstream to implement setting it in the proxy settings.

@fujunwei
Copy link
Contributor

fujunwei commented Dec 8, 2016

@rogerwang Do you mean the usage of the API will be

var password = URLEncoder(password)
nw.App.setProxyConfig('user:' + password + '@host:port')

The username/password will be saved with password manager and be used when that is required?

@fujunwei
Copy link
Contributor

fujunwei commented Feb 8, 2017

@rogerwang I suggest that a callback need to be added to handle the username/password because setProxyConfig has supported pac url.

@stale
Copy link

stale bot commented Feb 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 3, 2018
@stale stale bot closed this as completed Feb 6, 2018
@rogerwang rogerwang reopened this Feb 6, 2018
@stale stale bot removed the stale label Feb 6, 2018
@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot unassigned fujunwei Feb 7, 2019
@stale stale bot unassigned fujunwei Feb 7, 2019
@stale stale bot added the stale label Feb 7, 2019
@stale stale bot closed this as completed Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants