Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no migration of 0.12.3 websql db during 0.14.6 upgrade #5018

Closed
garfield69 opened this issue Jun 23, 2016 · 5 comments
Closed

no migration of 0.12.3 websql db during 0.14.6 upgrade #5018

garfield69 opened this issue Jun 23, 2016 · 5 comments
Assignees

Comments

@garfield69
Copy link

garfield69 commented Jun 23, 2016

when we upgrade our 0.12.3 nwjs to 0.14.6 we find that our websql database and local storage have not been migrated.
I spotted recently closed tickets regarding local storage and 0.15.3, so I ran a migration from 0.12.3 to 0.15.3.
While I can confirm that the local storage has been migrated successfully, the database file has not been.

below are the file paths for our database on our 0.12.3 environment on a widows 7 x32 sandbox should you find it useful.

 Directory of C:\Users\<username>\Local Settings\DuckieTV-Standalone\databases
Databases.db
Databases.db-journal
 Directory of C:\Users\<username>\Local Settings\DuckieTV-Standalone\databases\file__0
1

[edit]
paths under 0.15.3

C:\Users\<username>\Local Settings\DuckieTV-Standalone\User Data\Default\databases
C:\Users\<username>\Local Settings\DuckieTV-Standalone\User Data\Default\databases\chrome-extension_melhceajfalkiphejlgpncoljkdehjjh_0

Did you deliberately leave out websql database migrations, or is this an oversight?

@rogerwang
Copy link
Member

@rogerwang
Copy link
Member

I overlooked your notes on 0.15.3. It should be a bug, will try to fix it.

@rogerwang rogerwang self-assigned this Jun 23, 2016
rogerwang added a commit that referenced this issue Jun 23, 2016
rogerwang added a commit that referenced this issue Jun 23, 2016
rogerwang added a commit that referenced this issue Jun 23, 2016
@garfield69
Copy link
Author

Thank you for the prompt fix 😄

rogerwang added a commit that referenced this issue Jun 24, 2016
rogerwang added a commit that referenced this issue Jun 24, 2016
rogerwang added a commit that referenced this issue Jun 24, 2016
@garfield69
Copy link
Author

Excellent. Just tried it out with nightly http://dl.nwjs.io/live-build/06-24-2016/nw15-e925644-2a42a57-3ee2c58-8655cb9/v0.15.4/nwjs-sdk-v0.15.4-win-ia32.zip and I can confirm that migration from 0.12.3 to 0.15.4 worked for us.

question: I noticed that most of the migration fixes (local storage, indexdb, websql) appear to focus on OS_WIN. Could you confirm that these migration fixes will trickle their way into the other nwjs platforms (MacOSX, linux, Android) at some point?

@rogerwang
Copy link
Member

Other platform is supported as well.

On Fri, Jun 24, 2016, 2:54 PM garfield69 notifications@github.com wrote:

Excellent. Just tried it out with nightly
http://dl.nwjs.io/live-build/06-24-2016/nw15-e925644-2a42a57-3ee2c58-8655cb9/v0.15.4/nwjs-sdk-v0.15.4-win-ia32.zip
and I can confirm that migration from 0.12.3 to 0.15.4 worked for us.

question: I noticed that most of the migration fixes (local storage,
indexdb, websql) appear to focus on OS_WIN. Could you confirm that these
migration fixes will trickle their way into the other nwjs platforms
(MacOSX, linux, Android) at some point?


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#5018 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAKGGV60-B2paSGUj5VqK124YUA008fdks5qO38HgaJpZM4I8WZU
.

GnorTech pushed a commit that referenced this issue Jul 15, 2016
rogerwang added a commit that referenced this issue Jul 21, 2016
rogerwang added a commit that referenced this issue Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants