White border on main window with frame:true (was Dark grey on previous versions)

[vankasteelj]

Hi,

NWJS Version : 0.38.4-sdk
Operating System : Windows 10

Expected behavior

The "frame", the outline of the window was invisible, it's now a 1 or 2px white line. On Chrome, it's a black line.

Actual behavior

The "outline" of the app is white now, for some reason. The devtool window outline is black however.

How to reproduce

open a nwjs window with "frame: true"

============

Here are two screenshots: 1 of the main window on a colored background (to show the white), 1 of the devtool window on a white background (to show the black).

[TheJaredWilcurt]

That 1px (or 2px on HDPI screens) border comes from Windows Theme color.

The border will inherit the theme color. When the app is not in focused it will be black or a very dark version of the color (orange -> dark brown in the above example). You can make a frameless app if you want complete control of all the pixels, but will need to create your own buttons for minimize/maximize/restore/close.

Example:

[vankasteelj]

Right, but that doesn't explain why there's a black border on Chrome (itself & devtool) and nwjs' devtool, while it's white on nwjs itself.

[TheJaredWilcurt]

Because those windows are not opting in to the OS's color theme. The devtools use a light gray title bar. You need to acknowledge that the frame surrounding your app will be different in each OS. You can either let your app live inside a standard framed window that the OS gives you, or remove the frame to have complete control over the UI in all OS's.

[vankasteelj]

Let me phrase this another way:

• 0.32.4: dark grey border
• 0.36.4: dark grey border
• 0.37.4: white border
• 0.38.4: white border

I'm asking for the return of the dark grey border.

Examples with 0.32.4 vs 0.37.4:

[vankasteelj]

as of 0.44.3, the dark grey border is back!