NW2: nw.App.crashRenderer() doesn't kill nw like NW1 does

[bodo22]

Via issue #7339

NWJS Version : nw1 vs nw2 behaviour, seemingly independent of nw.js version
Operating System : Ubuntu 16.4 LTS

Expected behavior

With nw1, when testing a renderer crash with nw.App.crashRenderer(), the whole nw process dies.

Actual behavior

With nw2, the nw process is not killed completely.

How to reproduce

• Start the current nw.js version (0.44.2) with the chromium flag --disable-features=nw2.

• Execute nw.App.crashRenderer();
  -> nw completely dies

• Start the current nw.js version (0.44.2) without the chromium flag --disable-features=nw2.

• Execute nw.App.crashRenderer();
  -> nw doesn't die, but shows an "Oh Snap" error screen

Related (future) thoughts:

There are probably 2 use cases when a nw renderer dies:

1. don't let the user decide on anything, immediately just kill the whole process.
2. let the user interact & decide and what to do, e.g. let him write some text and allow him to send debugging logs etc.

Maybe it makes sense to handle crashing differently in the future, maybe based on a manifest file parameter, e.g. if kiosk is set, or to make it more explicit, a new parameter? Another idea would be to just execute some "renderer died" middleware code, to let the developer decide what to do.

[rogerwang]

This is fixed in git and will be available in the next nightly build.

[gpetrov]

@rogerwang - but now the whole nwjs process just disappears on crash? How can we open a new popup for the user to report an issue? As discussed in #7339 (comment)

[rogerwang]

This is just to keep the same behavior with NW1. The enhanced crash handling will be implemented later.

[arudnev]

@rogerwang, I just checked it with the following build on macOS:
http://dl.nwjs.io/live-build/nw44/20200225-162000/f721a1faf/v0.44.3/
It still shows "Aw, Snap!" with Close button.

[rogerwang]

@arudnev thanks. It seems to remain opening when devtools is opened. Will fix it soon.

[bodo22]

Any update on this, can i help somehow?

Same behaviour still happening with current build
nw.js Version: 0.48.1
OS: ubuntu 16 & ubuntu 20

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bodo22]

Bumping.

Same behaviour still happening with current build
nw.js Version: 0.60.0
tested OSes: ubuntu 16 LTS & ubuntu 20 LTS