Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Stop iframe mini-browser from opening new windows and open new urls in existing window. #801

Closed
scottgmeadows opened this issue Jun 18, 2013 · 8 comments

Comments

@scottgmeadows
Copy link

I'm currently working on a "mini-browser" using the new iframe features (https://github.com/rogerwang/node-webkit/wiki/Mini-browser-in-iframe), but new windows opening (via hrefs, js or flash content) is problematic for my use case.

Wondering about the possibility of a 'nwnopopups' feature that makes all the types of window open events open the new url in the existing root window.

@adampetrie
Copy link

+1 for this.

Without a way to manage windows (or ideally, prevent them from opening) the current mini-browser in an iframe doesn't really work for me either.

The issue here is that sandboxing the iframe also kills all plugins so I think we have to choose between no Flash content and no popups or allowing both.

@Anonyfox
Copy link

+1 for no popups. generally i see it as an advantage to not show flash content ever. No annoying ads or dealing with security issues, and generally not wasting CPU (flash players are quite expensive) or laptop battery energy.

@theabraham
Copy link
Contributor

Hmm, I recently ran into this issue with an iframe to a site that iframe's in ads. The ads popup in a separate window which isn't something I want for my users. Anyone have ideas on managing this? Is there a way to block popups from our end, or is this something that'd need to be implemented in node-webkit?

@adampetrie
Copy link

@theabraham - This might work for you: http://www.html5rocks.com/en/tutorials/security/sandboxed-iframes/

The issue with it is that Flash is also blocked. Ideally NW would have a feature that blocks popups but allows plugins.

@idibidiart
Copy link

+1. I think fixing this would help NW tremendously in that many niche-specific "Custom Browser" apps could then be built with it, without such annoying popups.

@heavyk
Copy link
Contributor

heavyk commented Sep 30, 2013

+1 👍

@michapixel
Copy link

flash can easily be blocked right away by not providing a plugin
resp. filling

"webkit": {
"plugin": false}

in apps json.

micha

2013/10/1 heavyk notifications@github.com

+1 [image: 👍]


Reply to this email directly or view it on GitHubhttps://github.com//issues/801#issuecomment-25414462
.

@rogerwang
Copy link
Member

This has been fixed by new-win-policy event handler in nwgui.Window.

@scottgmeadows scottgmeadows changed the title Feature Request: Stop iframe mini-browser from opening new windows and open new urls in existing window. Feature Request: Stop iframe mini-browser from opening new windows and open new urls in existing window. Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants