test case for issue #4007 #4242
Conversation
| import sys | ||
|
|
||
| if platform.system() === 'Darwin': | ||
| print 'Skipped test for Mac due to a blocking issue #4165' |
There was a problem hiding this comment.
If this case applies to OSX as well, why would we want to skip this case?
There was a problem hiding this comment.
I will turn it on once the issue is fixed. I prefer not to fail any test.
Roger Wang notifications@github.com于2016年1月14日周四 23:28写道：
In test/remoting/issue4007-reload-lost-app-window/test.py
#4242 (comment):@@ -0,0 +1,34 @@
+import time
+import os
+import platform
+import sys
+
+if platform.system() === 'Darwin':
- print 'Skipped test for Mac due to a blocking issue Mac: Right click -> Reload App will close windows but not start again #4165'
If this case applies to OSX as well, why would we want to skip this case?
—
Reply to this email directly or view it on GitHub
https://github.com/nwjs/nw.js/pull/4242/files#r49739408.
There was a problem hiding this comment.
Preferring not to fail any test is not the right thing to do here. The problem should not be covered.
|
Changed per @rogerwang 's request |
|
It should be squashed into a single commit. |
|
@rogerwang Updated |
| driver.find_element_by_id('reloadapp').click() | ||
| # wait 10s for reload complete | ||
| # on Linux, the reload is quite slow | ||
| time.sleep(10) |
There was a problem hiding this comment.
Is there any better way to do this rather than simply sleeping for random 10s? e.g. some blocking function call or event returns when the reload completes.
This test case will be skipped for Mac due to #4165