Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoUpdater][OSX] add squirrel auto updater #5722

Closed
wants to merge 2 commits into from

Conversation

jtg-gg
Copy link
Member

@jtg-gg jtg-gg commented Feb 23, 2017

Roger Wang, this is my pull request for the auto updater
this will also needs nwjs/chromium.src#66

The squirrel windows auto update is included, in this commit
the windows version can be done in javascript only, it will do IPC with the squirrel updater

@rogerwang
Copy link
Member

Great. Thanks! Will look to merge it. CC #233

@rogerwang
Copy link
Member

Please include documentation change as well.

@jtg-gg
Copy link
Member Author

jtg-gg commented Feb 23, 2017

ok @rogerwang, will do it within this 1-2days

@jtg-gg jtg-gg force-pushed the nw20-autoupdater branch 2 times, most recently from 891b9c9 to c64d2b6 Compare February 23, 2017 13:18
@jtg-gg
Copy link
Member Author

jtg-gg commented Feb 23, 2017

the documentation is done (included in this pull request)
https://github.com/jtg-gg/node-webkit/blob/nw20-autoupdater/docs/References/AutoUpdater.md

@rogerwang
Copy link
Member

I see the docs comes from http://electron.atom.io/docs/api/auto-updater/ with modifications.

After PR merged, is NW supposed to work in the same way as described in the doc? There are several external tools mentioned in the doc, including electron-winstaller, electron-builder, grunt-electron-installer, nuts, squirrel-updates-server, squirrel-release-server. Are they tested to work with this PR? -- just want to know what has already been tested on your side and I'll try the others.

@jtg-gg
Copy link
Member Author

jtg-gg commented Feb 24, 2017

@rogerwang my implementation was closely following the electron api, with very little modification.

as for the windows installer, I personally have tried electron-wininstaller, and it works with nw.js
I haven't try the other 2 windows packager

as for the server, I was trying squirrel-updates-server, but it is too complicated for my test / needs
at the end I setup my own http server. The other 2 sever, I never tried

@sashahilton00
Copy link

Is this going to be integrated into nw.js anytime soon? Would be great to have squirrel delta updates, but if not will roll my own updater...

@oaleynik
Copy link
Contributor

@rogerwang do you think this can land any time soon? 🙏🏻

@vinaynb
Copy link

vinaynb commented Jul 17, 2017

@sashahilton00 did you manage to create your solution for delta updates ?

@Ajeey
Copy link

Ajeey commented Sep 8, 2017

@rogerwang Any update on when are you merging the PR? Auto update, specifically delta updates is crucial for a desktop app. This functionality alone could be a deal breaker when choosing between nwjs OR electron.

@vinaynb
Copy link

vinaynb commented Sep 15, 2017

@rogerwang any updates on this ? This is a must for my use case as i don't need to update nw binary itself, just the app code.

@rogerwang
Copy link
Member

@vinaynb this is about updating NW binary, not the application code.

@Ajeey currently there are solutions for auto-update as an add-on. So we are not in a hurry to make it as built-in feature. For this PR, we are waiting for an implementation for Windows as well.

@stale
Copy link

stale bot commented Sep 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 10, 2018
@stale stale bot closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants