DotNET: Implement new bootstrap #1756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhett12321
commented
May 5, 2024
Comment on lines
+33
to
+37
| function(add_shared_plugin target) | ||
| add_library(${target} SHARED ${ARGN}) | ||
| configure_plugin(${target}) | ||
| endfunction() | ||
|
|
There was a problem hiding this comment.
PInvoke cannot accessed exported symbols of "Module" visible libraries, so I added a new function here with different visibility.
We can also change the plugin default to have shared visibility, which would allow C# code to directly call exports from other NWNX plugins.
I can inline this directly in DotNET/CMakeLists if you do not want this added here.
jhett12321
commented
May 5, 2024
Comment on lines
+179
to
+182
| if (messageType == "ON_NWNX_LOADED") | ||
| { | ||
| Bootstrap(); | ||
| } |
There was a problem hiding this comment.
Bootstrapping was moved to the end of NWNX init to allow for all enabled NWNX plugins to be loaded, in-case C# code attempts to use exports from other plugins.
jhett12321
commented
May 5, 2024
There was a problem hiding this comment.
These files are completely unused by the SWIG build, and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method of bootstrapping C# assemblies that reduces the boilerplate code in C# & C++, and improves portability with simple C-style exports that matches the convention used by other NWNX plugins.
The updated bootstrapping code is backwards compatible, and should not be ABI breaking.