WIP: Commands to get and set environment variables #265
Conversation
| { | ||
| std::string varname = s.substr(0, equals); | ||
| std::string value = s.substr(equals+1, std::string::npos); | ||
| if (setenv(varname.c_str(), value.c_str(), 1) == 0) |
There was a problem hiding this comment.
I think this is problematic. setenv is not thread safe. I think a safer design would be to extend the Config service so that you can change config settings that way.
There was a problem hiding this comment.
Thread safety is not an issue since this all runs on the main thread. But you make a valid point that they are better suited for the Config service. I'm thinking map<string varname, string override_value> that you can set through the command line, and some way for plugins to register a callback when a config option changes.
The big advantage there would be that changes would not persist across NWNX reboots.
Adding a WIP tag here.
mtijanic
changed the title
|
(Closing this for not as all of the code is gonna be thrown away anyway) |
Incremental update to the commands per #6 , allows querying and setting local variables. To be used with hot reload commands that are WIP.