PoolPlus: Make .defineTable() throw a TypeError (instead of Error) …

…if name is not a string
nwoltman · Apr 5, 2017 · b6489fe · b6489fe
1 parent 2ca6e43
commit b6489fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/PoolPlus.js b/lib/PoolPlus.js
@@ -92,7 +92,7 @@ class PoolPlus extends Pool {
    */
   defineTable(name, schema, migrationStrategy) {
     if (typeof name !== 'string') {
-      throw new Error('The table name must be a string');
+      throw new TypeError('The table name must be a string');
     }
     if (this._tables.has(name)) {
       throw new Error(`A table called "${name}" has already been defined for this pool`);

diff --git a/test/unit/PoolPlus.test.js b/test/unit/PoolPlus.test.js
@@ -103,7 +103,8 @@ describe('PoolPlus', () => {
     });
 
     it('should throw if the table name is not a string', () => {
-      should.throws(() => pool.defineTable(/table/), /The table name must be a string/);
+      (() => pool.defineTable(/table/)).should.throw(TypeError);
+      (() => pool.defineTable(/table/)).should.throw(/The table name must be a string/);
     });
 
     it('should throw if no columns are provided', () => {