-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickfix for missing import duplicates identifier in coc.nvim #66
Comments
I'm quite tired right now, but after I get enough rest I'll investigate this issue more and then comment what I discover. |
I'll take a look at what happens for similar in vscode, if that shows the same issue then the answer is clear. We should be able to find out what messages are sent to/from the LSP and find out what's at fault in that way |
Here's a log file that shows the communication between coc.nvim and |
Looking at that log, we supply a single edit which seems to have 2 things going on:
Firstly, the range start/end seem to be reversed, which may be why the text is not replaced but appended. Secondly, the edit is supplied in the "old" and "new" forms. I was of the belief that
|
Hopefully fixed in 3941003 |
I tried to check if this bug was fixed, but even before I updated to
I'll try to check later, as it seems that it's a problem from my side. |
Quickfix was borken in vscode for a long time, not sure what the status is post-update - I assume I fixed it... but that may have broken others. |
I tested this in coc.nvim. I might install VSCode to check if it works there or not. |
I don't know if the issue stems from
purescript-language-server
or from coc.nvim. If the issue is indeed from coc.nvim, please tell me and then I'll create an issue there.Here's a video demonstrating the issue.
(Sorry for bad quality, for some reason imgur trims down the video's quality)
The text was updated successfully, but these errors were encountered: