This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
Export applicants with arbitrary tags #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamkank
reviewed
Jan 21, 2019
| @@ -460,8 +460,28 @@ class GenericApplicantContainer extends React.Component { | |||
| } | |||
| }); | |||
| const filteredApplicants = this.filterApplicants(checkedApplicants); | |||
| const fields = ['firstName', 'lastName', 'email', 'id', 'tags']; | |||
| const fields = ['firstName', 'lastName', 'email', 'id', 'tags.accepted', 'tags.abc']; | |||
There was a problem hiding this comment.
Can we set fields to an empty array?
There was a problem hiding this comment.
we could, i think it's better if we keep firstName, lastName, email, and id so it keeps it nicely ordered, what do you think?
There was a problem hiding this comment.
That's a good point, I'm fine with keeping firstName, lastName, email, and id, but can we get rid of tags.accepted, tags.abc?
There was a problem hiding this comment.
yup sounds good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #
👷 Changes
Exporting selected applicants should include all fields and tags of each applicant
💭 Notes
🔦 Testing Instructions
Explain how to test your changes, if applicable.