Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage + scaling #56

Merged
merged 74 commits into from Aug 30, 2018

Conversation

@bobheadxi
Copy link
Contributor

bobheadxi commented Aug 17, 2018

馃師 Ticket(s): Closes #34


馃懛 Changes

First few rows of the homepage + lots of new scaling stuff. I feel stuff is finicky... can't seem to get the fonts to quite match the Figma... SVG scaling needs improvmeent and very low widths

image
image
image

馃挱 Notes

Won't be including FAQ or Stories in this PR.

馃敠 Testing Instructions

make web
@bobheadxi bobheadxi requested a review from mingyokim Aug 21, 2018
@bobheadxi bobheadxi changed the title [WIP] Homepage + scaling Homepage + scaling Aug 21, 2018
@bobheadxi

This comment has been minimized.

Copy link
Contributor Author

bobheadxi commented Aug 25, 2018

@mingyokim @chamkank going to leave the footer for another PR - this is getting rather sizeable. This is ready for review

@bobheadxi bobheadxi moved this from 馃殌 In Progress to 馃攳 Pending Review in nwHacks 2019 Aug 25, 2018
@@ -48,7 +48,7 @@ class Login extends React.Component {
<form
onSubmit={this.login}
className="input-group">
<h2 className="pad-sides-xxl">Sign in</h2>
<h3 className="pad-sides-xxl margin-botom-m">Sign in</h3>

This comment has been minimized.

Copy link
@mingyokim

mingyokim Aug 29, 2018

Contributor

relevance to this PR? seems kinda unrelated - it could be in a separate PR next time

This comment has been minimized.

Copy link
@bobheadxi

bobheadxi Aug 29, 2018

Author Contributor

Sort of ripple effect because of some changes to h2 i had to make to accomodate the homepage styles

This comment has been minimized.

Copy link
@bobheadxi

bobheadxi Aug 29, 2018

Author Contributor

on that note... margin-botom is mispelled oops

Copy link
Contributor

mingyokim left a comment

Left a few comments, will test this out tonight

web/components/navbar/index.js Outdated Show resolved Hide resolved
web/components/navbar/index.js Outdated Show resolved Hide resolved
{l}
</div>
));
navbarRight.push(<div key={key += 1} className={LINK_CLASS}>{button}</div>);

This comment has been minimized.

Copy link
@mingyokim

mingyokim Aug 30, 2018

Contributor

This is not supposed to be here - LOGO_AND_LINKS means it does not contain the button

bobheadxi added 2 commits Aug 30, 2018
nwHacks 2019 automation moved this from 馃攳 Pending Review to 馃弳 Approved Aug 30, 2018
@bobheadxi bobheadxi merged commit 1b639f4 into master Aug 30, 2018
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
nwHacks 2019 automation moved this from 馃弳 Approved to 馃梼 Closed Aug 30, 2018
@bobheadxi bobheadxi deleted the web/home branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
nwHacks 2019
  
馃梼 Closed
2 participants
You can鈥檛 perform that action at this time.