This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
Homepage + scaling #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idIndex in redux store
|
@mingyokim @chamkank going to leave the footer for another PR - this is getting rather sizeable. This is ready for review |
mingyokim
reviewed
Aug 29, 2018
web/components/auth/Login/Login.js
Outdated
| @@ -48,7 +48,7 @@ class Login extends React.Component { | |||
| <form | |||
| onSubmit={this.login} | |||
| className="input-group"> | |||
| <h2 className="pad-sides-xxl">Sign in</h2> | |||
| <h3 className="pad-sides-xxl margin-botom-m">Sign in</h3> | |||
There was a problem hiding this comment.
relevance to this PR? seems kinda unrelated - it could be in a separate PR next time
There was a problem hiding this comment.
Sort of ripple effect because of some changes to h2 i had to make to accomodate the homepage styles
There was a problem hiding this comment.
on that note... margin-botom is mispelled oops
mingyokim
reviewed
Aug 29, 2018
mingyokim
suggested changes
Aug 30, 2018
web/components/navbar/index.js
Outdated
| {l} | ||
| </div> | ||
| )); | ||
| navbarRight.push(<div key={key += 1} className={LINK_CLASS}>{button}</div>); |
There was a problem hiding this comment.
This is not supposed to be here - LOGO_AND_LINKS means it does not contain the button
mingyokim
approved these changes
Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #34
👷 Changes
First few rows of the homepage + lots of new scaling stuff. I feel stuff is finicky... can't seem to get the fonts to quite match the Figma... SVG scaling needs improvmeent and very low widths
💭 Notes
Won't be including FAQ or Stories in this PR.
🔦 Testing Instructions