Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR open which isn't a member of the repo gets ##[error]Missing access token #32

Closed
kaihendry opened this issue Feb 27, 2020 · 7 comments

Comments

@kaihendry
Copy link

image

https://github.com/kaihendry/dabase.com/runs/471466202 is the same as kaihendry/dabase.com#2 (comment)

I'm not sure how to address this.

@nwtgck
Copy link
Owner

nwtgck commented Feb 27, 2020

@kaihendry Hello again.

I think the action was triggered by @cheeaun. I guess someone who is not a maintainer can not use the secrets. As you said before, it may be permission problem.

The latest deployment to Netlify was successful on master branch triggered by you.
image

@nwtgck
Copy link
Owner

nwtgck commented Feb 27, 2020

I found official description about the secret on GitHub.

Secrets are not passed to workflows that are triggered by a pull request from a fork.

image

I found a detail explanation: Creating and storing encrypted secrets - GitHub Help. It says exception is only GITHUB_TOKEN.

@kaihendry
Copy link
Author

hhhmmmm... so this makes this action kindof useless for external contributions then?

Or do you think we can get around the secrets limitation?

@nwtgck
Copy link
Owner

nwtgck commented Feb 27, 2020

hhhmmmm... so this makes this action kindof useless for external contributions then?
I think so too...

Unfortunately, I have no workaround.

@kaihendry
Copy link
Author

I posted on https://github.community/t5/GitHub-Actions/Secrets-for-PRs-who-are-not-collaborators/td-p/47900

I mean maybe it's kindof dangerous to have Netlify publish a site ... struggling to weigh up the risks, since the PR is on Github to begin with.

@nwtgck
Copy link
Owner

nwtgck commented Feb 27, 2020

Very great! I want to keep watching the post.

@nwtgck
Copy link
Owner

nwtgck commented Feb 27, 2020

This issue seems to be a general issue of GitHub Actions. So I close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants