Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show old urls on pull-request #482

Closed

Conversation

peaceiris
Copy link
Contributor

@peaceiris peaceiris commented Mar 23, 2021

This change allows a pull-request has a list of other deploy preview URLs, not only the latest one.

Tested on peaceiris/hugo-theme-iris#306

Screen.Recording.2021-03-23.at.20.30.39.mov

@nwtgck
Copy link
Owner

nwtgck commented Mar 23, 2021

Very interesting.

But, I thing this feature is realized by opening the old deploy preview URL in the CI checks below. That is easier to follow the specific commit with Git SHA1 and also its message.

actions-netlify-ci-check.mp4

@peaceiris
Copy link
Contributor Author

Thank you for your review, That sounds better. I will do so!

@peaceiris
Copy link
Contributor Author

I just missed the response from the enable-commit-status option. Thanks.

Screen.Recording.2021-03-24.at.12.42.55.mov

@peaceiris peaceiris closed this Mar 24, 2021
@peaceiris peaceiris deleted the multiple-deploy-preview-urls branch March 24, 2021 03:44
@polarathene
Copy link

But, I thing this feature is realized by opening the old deploy preview URL in the CI checks below. That is easier to follow the specific commit with Git SHA1 and also its message.

This could be a nice feature, but once you use an alias it is no longer valid. Perhaps a better improvement (so that it can be used beyond the status check shown here), is to also include the deploy ID as an output. That enables using it for accessing prior build previews as well as linking to their build log pages.

As comment is not customizable, I use a separate action for managing the deploy comment, I could keep a <details> list this way (but using comment history makes sense to me when this is relevant). I use the alias for preview link, but if I wanted to link to the log as well I'd need that deploy ID value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants