Merge pull request #131 from cgrossde/issue-130-CFBundleIdentifier

Fixes #130, make CFBundleIdentifier dependent on package name if not set...
nwutils · Dec 7, 2014 · ef3a489 · ef3a489
2 parents 7886187 + 387b4f5
commit ef3a489
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -177,6 +177,11 @@ module.exports = {
             }
         });
 
+        // Bundle identifier based on package name
+        if(options.CFBundleIdentifier === undefined) {
+            options.CFBundleIdentifier = 'com.node-webkit-builder.' + options.CFBundleName.toLowerCase().replace(/[^a-z\-]/g,'');
+        }
+
         // Read the input file
         return readFile(plistInput, 'utf8')
             // Parse it

diff --git a/test/expected/Info.plist b/test/expected/Info.plist
@@ -13,7 +13,7 @@
     <key>CFBundleIconFile</key>
     <string>nw.icns</string>
     <key>CFBundleIdentifier</key>
-    <string>com.intel.nw</string>
+    <string>com.node-webkit-builder.testapp</string>
     <key>CFBundleInfoDictionaryVersion</key>
     <string>6.0</string>
     <key>CFBundleName</key>