Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM audit reports nw-builder as insecure #500

Closed
ea2973929 opened this issue Dec 3, 2018 · 6 comments · Fixed by #502
Closed

NPM audit reports nw-builder as insecure #500

ea2973929 opened this issue Dec 3, 2018 · 6 comments · Fixed by #502

Comments

@ea2973929
Copy link

See https://david-dm.org/nwjs/nw-builder

The problematic package is lodash and there are new versions available that can easily fix this.

npm audit with even low security problems will fail our builds (because npm audit does not distinguish between different levels) so an updated nw-builder would be very welcome.

@kessler
Copy link
Contributor

kessler commented Dec 18, 2018

@ea2973929 I looked into this. It seems there is a potential for breaking changes as a result of the update. If you could submit a PR it would be great.

@vankasteelj
Copy link
Contributor

vankasteelj commented Jan 11, 2019

This seems pretty straightforward, as the issue is platform-overrides module by @adam-lynch. PR there and/or port the code here.

I would rather have the code ported here, as it will void the issue with duplicate lodash (used here and there)

@kessler
Copy link
Contributor

kessler commented Jan 12, 2019

@vankasteelj could you submit a PR ?

@vankasteelj
Copy link
Contributor

Yeah probably, but idk when I'll have the time, monday maybe

@vankasteelj
Copy link
Contributor

if @adam-lynch is there, adam-lynch/platform-overrides#6

I'll PR a port to nw-builder as well

vankasteelj added a commit to vankasteelj/nw-builder that referenced this issue Jan 14, 2019
- fixes lodash vulnerability issue
- closes nwutils#500
vankasteelj added a commit to vankasteelj/nw-builder that referenced this issue Jan 14, 2019
- fixes lodash vulnerability issue
- closes nwutils#500
@vankasteelj
Copy link
Contributor

Ok, PR done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants