Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect file permissions when building linux or osx packages in Windows #716

Closed
1 of 3 tasks
sysrage opened this issue Nov 27, 2022 · 1 comment
Closed
1 of 3 tasks
Labels
bug Priority: 1

Comments

@sysrage
Copy link
Contributor

sysrage commented Nov 27, 2022

Issue Type

  • Bug Fix
  • Feature
  • Other

Current/Missing Behaviour

Any Linux or macOS packages built from Windows will have incorrect permissions set for executable files. These need the +x bit set, but this is stripped off when extracting files in Windows.

Expected/Proposed Behaviour

Either find a way to preserve the +x bits for all NW.js files (and anything else packaged with the app) or show a warning to users that osx and linux packages should not be built from Windows.

Additional Info

  • Operating System: Windows
  • Node version: 18.12.0
  • NW.js version: 0.70.1
  • Repro link: Any linux or osx build in Windows
@sysrage sysrage added the bug Priority: 1 label Nov 27, 2022
@sysrage
Copy link
Contributor Author

sysrage commented Nov 28, 2022

Based on several conversations, there is likely no good way to keep permissions set properly while building in Windows. We should probably just list this limitation in the documentation and suggest that users build in WSL or a VM. A warning can also be shown if users attempt an osx or linux build in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: 1
Projects
None yet
Development

No branches or pull requests

1 participant