Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing infinite error loop in test #7

Merged
merged 2 commits into from Jun 22, 2014
Merged

Preventing infinite error loop in test #7

merged 2 commits into from Jun 22, 2014

Conversation

adam-lynch
Copy link
Collaborator

This helps a little but for some weird reason there are still four identical errors thrown.

The error is thrown because the request for http://localhost:63061/package.json fails. Is it expected to fail when requested from 0.0.2? Or should 0.0.2 get the manifest and then realise the app is up to date?

@adam-lynch
Copy link
Collaborator Author

Ok, now I've locked it down to throwing just one error. See last commit.

@edjafarov
Copy link
Collaborator

Well so far the tests are not perfect yet.
Because we are not tracking whether the updated app was started. We are just checking that the app's folder was updated.
Ideally on start the desktop app should GET /iamtheversion/ url be AJAX and we should wait inside our tests for the call an ensure that version was updated to 0.0.2. We should response "{result:OK}" from server and getting the response the desktop app will teardown itself.
Otherwise we are getting error case and should show errors.
I will merge the request so far though.
It might make sense to think about #1

edjafarov added a commit that referenced this pull request Jun 22, 2014
Preventing infinite error loop in test
@edjafarov edjafarov merged commit 4d7a705 into nwutils:master Jun 22, 2014
@edjafarov edjafarov mentioned this pull request Jun 22, 2014
@adam-lynch adam-lynch deleted the prevent-error-loop branch June 22, 2014 13:03
@adam-lynch
Copy link
Collaborator Author

Those improvements sound good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants