Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .background handling to OSX .pkg in packaging script #9

Closed
sanusart opened this issue Aug 9, 2015 · 2 comments
Closed

Add .background handling to OSX .pkg in packaging script #9

sanusart opened this issue Aug 9, 2015 · 2 comments
Labels
enhancement

Comments

@sanusart
Copy link
Collaborator

sanusart commented Aug 9, 2015

Add .background handling to OSX .pkg in packaging script, fall-back to default (nwjs image I guess) image if not set.
@morsdyce
Copy link
Contributor

morsdyce commented Aug 9, 2015

I disagree, default should be no image.

Most pkg files do not include backgrounds and theres no reason to include NW.js branding on it.

@sanusart
Copy link
Collaborator Author

sanusart commented Aug 9, 2015

Right. No defaults then.

On Sun, Aug 9, 2015, 10:31 AM Maayan Glikser notifications@github.com
wrote:

I disagree, default should be no image.

Most pkg files do not include backgrounds and theres no reason to include
NW.js branding on it.

—
Reply to this email directly or view it on GitHub
#9 (comment)
.

sanusart added a commit that referenced this issue Aug 13, 2015
@sanusart
FEATURE (packaging): Add .background handling to OSX .pkg
5c04a5b 
- Add .background handling to OSX .pkg in packaging script

Closes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanusart @morsdyce