Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

Commit 24eb831

Browse files
authored
fix(core): support new name for enforce-module-boundaries eslint rule (#742)
1 parent 7dd60b2 commit 24eb831

2 files changed

Lines changed: 28 additions & 23 deletions

File tree

packages/core/src/tasks/check-module-boundaries.spec.ts

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -53,26 +53,29 @@ describe('load-module-boundaries', () => {
5353
expect(boundaries).toEqual(MOCK_BOUNDARIES);
5454
});
5555

56-
it('should load from eslint if boundaries not in config', async () => {
57-
const eslintConfigSpy = jest
58-
.spyOn(ESLintNamespace, 'ESLint')
59-
.mockReturnValue({
60-
calculateConfigForFile: jest.fn().mockResolvedValue({
61-
rules: {
62-
'@nrwl/nx/enforce-module-boundaries': [
63-
1,
64-
{ depConstraints: MOCK_BOUNDARIES },
65-
],
66-
},
67-
}),
68-
} as unknown as ESLintNamespace.ESLint);
69-
writeJson<NxDotnetConfig>(appTree, CONFIG_FILE_PATH, {
70-
nugetPackages: {},
71-
});
72-
const boundaries = await loadModuleBoundaries('', appTree);
73-
expect(eslintConfigSpy).toHaveBeenCalledTimes(1);
74-
expect(boundaries).toEqual(MOCK_BOUNDARIES);
75-
});
56+
it.each([
57+
'@nrwl/nx/enforce-module-boundaries',
58+
'@nx/enforce-module-boundaries',
59+
])(
60+
'should load from eslint if boundaries not in config',
61+
async (eslintRuleName) => {
62+
const eslintConfigSpy = jest
63+
.spyOn(ESLintNamespace, 'ESLint')
64+
.mockReturnValue({
65+
calculateConfigForFile: jest.fn().mockResolvedValue({
66+
rules: {
67+
[eslintRuleName]: [1, { depConstraints: MOCK_BOUNDARIES }],
68+
},
69+
}),
70+
} as unknown as ESLintNamespace.ESLint);
71+
writeJson<NxDotnetConfig>(appTree, CONFIG_FILE_PATH, {
72+
nugetPackages: {},
73+
});
74+
const boundaries = await loadModuleBoundaries('', appTree);
75+
expect(eslintConfigSpy).toHaveBeenCalledTimes(1);
76+
expect(boundaries).toEqual(MOCK_BOUNDARIES);
77+
},
78+
);
7679
});
7780

7881
// eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -84,7 +87,7 @@ describe('enforce-module-boundaries', () => {
8487
jest.spyOn(ESLintNamespace, 'ESLint').mockReturnValue({
8588
calculateConfigForFile: jest.fn().mockResolvedValue({
8689
rules: {
87-
'@nrwl/nx/enforce-module-boundaries': [
90+
'@nx/enforce-module-boundaries': [
8891
1,
8992
{ depConstraints: MOCK_BOUNDARIES },
9093
],

packages/core/src/tasks/check-module-boundaries.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,13 @@ export async function loadModuleBoundaries(
8080
.calculateConfigForFile(`${root}/non-existant.ts`)
8181
.catch(() =>
8282
Promise.resolve({
83-
rules: { '@nrwl/nx/enforce-module-boundaries': [] },
83+
rules: { '@nx/enforce-module-boundaries': [] },
8484
}),
8585
);
8686
const [, moduleBoundaryConfig] =
87-
result.rules['@nrwl/nx/enforce-module-boundaries'] || [];
87+
result.rules['@nx/enforce-module-boundaries'] ||
88+
result.rules['@nrwl/nx/enforce-module-boundaries'] ||
89+
[];
8890
return moduleBoundaryConfig?.depConstraints ?? [];
8991
} catch {
9092
return [];

0 commit comments

Comments
 (0)