Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet): project with spaces do not bug out the command #379

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

asinino
Copy link
Contributor

@asinino asinino commented Feb 28, 2022

When a user has a project that contains a space in its name the command failed because it does not escape the space to the shell command.
Fixes #308

When a user has a project that contains a space in it's name the command
failed because it does not escaped the space to the shell command.
Fixes nx-dotnet#308
@nx-cloud
Copy link

nx-cloud bot commented Feb 28, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 5df3a4a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit dd4e16b into nx-dotnet:master Feb 28, 2022
github-actions bot pushed a commit that referenced this pull request Feb 28, 2022
## [1.9.2](v1.9.1...v1.9.2) (2022-02-28)

### Bug Fixes

* **dotnet:** project with spaces do not bug out the command ([#379](#379)) ([dd4e16b](dd4e16b))

Feb 28, 2022, 5:18 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Current folder with spaces does not watch
2 participants