fix(core): remove workaround for broken dotnet format builtin #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0f254ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/dotnet-format-fixed
branch
from
60f8cbf
to
0f254ab
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2022
## [1.10.1](v1.10.0...v1.10.1) (2022-05-20) ### Bug Fixes * **core:** remove workaround for broken dotnet format builtin ([#443](#443)) ([e0f04eb](e0f04eb)) May 20, 2022, 3:11 PM
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx .NET always runs dotnet-format via the tool, since the included version of the tool is broken.
When running dotnet-format as a tool, the command is formatted like:
This is causing failures in .NET SDK 6.0.300
Expected Behavior
Nx .NET takes advantage of the builtin since it is no longer broken.
When running dotnet-format as a tool, the command is formatted like:
The output of
dotnet tool run --helpshows the extra--'s before too, so this should work on older sdk versions as well as 6.0.300Related Issues
Fixes #435