Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node fails to compile due to error: 'nghttp2_option_set_max_settings' was not declared in this scope #679

Closed
BKPepe opened this issue Jun 7, 2020 · 5 comments
Closed

Node fails to compile due to error: 'nghttp2_option_set_max_settings' was not declared in this scope #679

BKPepe opened this issue Jun 7, 2020 · 5 comments

Comments

@BKPepe
Copy link
Contributor

BKPepe commented Jun 7, 2020

Trying to compile node 12.18.0 on environment: OpenWrt 19.07 (Turris Omnia - mvebu - cortex-a9 | Turris MOX - mvebu - cortexa53)

Log:

-I/path/build/staging_dir/toolchain-arm_cortex-a9+vfpv3-d16_gcc-7.5.0_musl_eabi/include/fortify -I/path/build/staging_dir/toolchain-arm_cortex-a9+vfpv3-d16_gcc-7.5.0_musl_eabi/include  -c
../src/node_http2.cc: In constructor 'node::http2::Http2Options::Http2Options(node::Environment*, node::http2::nghttp2_session_type)':
../src/node_http2.cc:208:5: error: 'nghttp2_option_set_max_settings' was not declared in this scope
     nghttp2_option_set_max_settings(
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_http2.cc:208:5: note: suggested alternative: 'nghttp2_session_get_local_settings'
     nghttp2_option_set_max_settings(
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     nghttp2_session_get_local_settings
libnode.target.mk:228: recipe for target '/path/build/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/node-v12.18.0/out/Release/obj.target/libnode/src/node_http2.o' failed
make[4]: *** [/path/build/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/node-v12.18.0/out/Release/obj.target/libnode/src/node_http2.o] Error 1

If you need more logs, I'd be glad to provide them.
@sans-ltd
Copy link

sans-ltd commented Jun 8, 2020

I'm also on this problem. The issue is that node does not pick the nghttp2 header from its deps folder but from staging_dir. The nghttp2 (1.39.2) there from openwrt is too old and lacks the symbol it complains about.
But I have no clue for now how to fix this.

@nxhack
Copy link
Owner

nxhack commented Jun 9, 2020

You need to backport the changes applied to master.

openwrt/openwrt@4e65838

@sans-ltd
Copy link

sans-ltd commented Jun 9, 2020

Yes this works, thanks nxhack!

@BKPepe
Copy link
Contributor Author

BKPepe commented Jun 9, 2020

You need to backport the changes applied to master.

Shouldn't we rather ask OpenWrt main repo to backport it to OpenWrt 19.07? Also, I think it can be good if there is a branch for openwrt-19.07 the same as in the packages feed.

admin-turris pushed a commit to CZ-NIC/turris-build that referenced this issue Jun 9, 2020
@ja-pa
patches/openwrt: nghttp2 update to version 1.41.0
3507816 
Fixes compilation problem with node package feed
nxhack/openwrt-node-packages#679
admin-turris pushed a commit to CZ-NIC/turris-build that referenced this issue Jun 17, 2020
@ja-pa
patches/openwrt: nghttp2 update to version 1.41.0
313ef75 
Fixes compilation problem with node package feed
nxhack/openwrt-node-packages#679
admin-turris pushed a commit to CZ-NIC/turris-build that referenced this issue Jun 17, 2020
@ja-pa
patches/openwrt: nghttp2 update to version 1.41.0
3a5dda1 
Fixes compilation problem with node package feed
nxhack/openwrt-node-packages#679
admin-turris pushed a commit to CZ-NIC/turris-build that referenced this issue Jun 19, 2020
@ja-pa @BKPepe
patches/openwrt: nghttp2 update to version 1.41.0
8a9c2a8 
Fixes compilation problem with node package feed
nxhack/openwrt-node-packages#679
ja-pa pushed a commit to ja-pa/openwrt that referenced this issue Jul 2, 2020
@dedeckeh @ja-pa
nghttp2: bump to 1.41.0
df3ac6e 
8f7b008b Update bash_completion
83086ba9 Update manual pages
c3b46625 Merge pull request from GHSA-q5wr-xfw9-q7xr
3eecc2ca Bump version number to v1.41.0, LT revision to 34:0:20
881c060d Update AUTHORS
f8da73bd Earlier check for settings flood
336a98fe Implement max settings option
ef415836 Revert "Add missing connection error handling"
979e6c53 Merge pull request openwrt#1459 from nghttp2/proxyprotov2
b7d16101 Add missing connection error handling
cd53bd81 Merge pull request openwrt#1460 from gportay/patch-1
e5625b8c Fix doc
c663349f integration: Add PROXY protocol v2 tests
854e9fe3 nghttpx: Always call init_forwarded_for
c60ea227 Update doc
49cd8e6 nghttpx: Add PROXY-protocol v2 support
3b17a659 Merge pull request openwrt#1453 from Leo-Neat/master
600fcdf5 Merge pull request openwrt#1455 from xjtian/long_serials
4922bb41 static_cast size parameter in StringRef constructor to size_t
aad86975 Fix get_x509_serial for long serial numbers
dc7a7df6 Adding CIFuzz
b3f85e2d Merge pull request openwrt#1444 from nghttp2/fix-recv-window-flow-control-issue
ffb49c6c Merge pull request openwrt#1435 from geoffhill/master
2ec58551 Fix receiving stream data stall
459df42b Merge pull request openwrt#1442 from nghttp2/upgrade-llhttp
a4c1fed5 Bump llhttp to 2.0.4
866eadb5 Enable session_create_idle_stream test, fix errors
5e13274b Fix typo
e0d7f7de h2load: Allow port in --connect-to
df575f96 h2load: add --connect-to option
1fff7379 clang-format-9
b40c6c86 Merge pull request openwrt#1418 from vszakats/patch-1
9bc2c75e lib/CMakeLists.txt: Make hard-coded static lib suffix optional
2d5f7659 Bump up version number to 1.41.0-DEV

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

Note this is cherry-pick from master. It fixes CVE-2020-11080
and  nxhack/openwrt-node-packages#679

Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
@ja-pa ja-pa mentioned this issue Jul 2, 2020
Closed
jow- pushed a commit to openwrt/openwrt that referenced this issue Jul 4, 2020
@dedeckeh
nghttp2: bump to 1.41.0
d46650d 
8f7b008b Update bash_completion
83086ba9 Update manual pages
c3b46625 Merge pull request from GHSA-q5wr-xfw9-q7xr
3eecc2ca Bump version number to v1.41.0, LT revision to 34:0:20
881c060d Update AUTHORS
f8da73bd Earlier check for settings flood
336a98fe Implement max settings option
ef415836 Revert "Add missing connection error handling"
979e6c53 Merge pull request #1459 from nghttp2/proxyprotov2
b7d16101 Add missing connection error handling
cd53bd81 Merge pull request #1460 from gportay/patch-1
e5625b8c Fix doc
c663349f integration: Add PROXY protocol v2 tests
854e9fe3 nghttpx: Always call init_forwarded_for
c60ea227 Update doc
49cd8e6 nghttpx: Add PROXY-protocol v2 support
3b17a659 Merge pull request #1453 from Leo-Neat/master
600fcdf5 Merge pull request #1455 from xjtian/long_serials
4922bb41 static_cast size parameter in StringRef constructor to size_t
aad86975 Fix get_x509_serial for long serial numbers
dc7a7df6 Adding CIFuzz
b3f85e2d Merge pull request #1444 from nghttp2/fix-recv-window-flow-control-issue
ffb49c6c Merge pull request #1435 from geoffhill/master
2ec58551 Fix receiving stream data stall
459df42b Merge pull request #1442 from nghttp2/upgrade-llhttp
a4c1fed5 Bump llhttp to 2.0.4
866eadb5 Enable session_create_idle_stream test, fix errors
5e13274b Fix typo
e0d7f7de h2load: Allow port in --connect-to
df575f96 h2load: add --connect-to option
1fff7379 clang-format-9
b40c6c86 Merge pull request #1418 from vszakats/patch-1
9bc2c75e lib/CMakeLists.txt: Make hard-coded static lib suffix optional
2d5f7659 Bump up version number to 1.41.0-DEV

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

Note this is cherry-pick from master. It fixes CVE-2020-11080
and  nxhack/openwrt-node-packages#679

Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
@BKPepe
Copy link
Contributor Author

BKPepe commented Jul 5, 2020

Closing as nghttp2 was updated in OpenWrt 19.07!

Good job, @ja-pa !

@BKPepe BKPepe closed this as completed Jul 5, 2020
phs07 pushed a commit to phs07/openwrt that referenced this issue Oct 3, 2020
@dedeckeh @phs07
nghttp2: bump to 1.41.0
d152292 
8f7b008b Update bash_completion
83086ba9 Update manual pages
c3b46625 Merge pull request from GHSA-q5wr-xfw9-q7xr
3eecc2ca Bump version number to v1.41.0, LT revision to 34:0:20
881c060d Update AUTHORS
f8da73bd Earlier check for settings flood
336a98fe Implement max settings option
ef415836 Revert "Add missing connection error handling"
979e6c53 Merge pull request openwrt#1459 from nghttp2/proxyprotov2
b7d16101 Add missing connection error handling
cd53bd81 Merge pull request openwrt#1460 from gportay/patch-1
e5625b8c Fix doc
c663349f integration: Add PROXY protocol v2 tests
854e9fe3 nghttpx: Always call init_forwarded_for
c60ea227 Update doc
49cd8e6 nghttpx: Add PROXY-protocol v2 support
3b17a659 Merge pull request openwrt#1453 from Leo-Neat/master
600fcdf5 Merge pull request openwrt#1455 from xjtian/long_serials
4922bb41 static_cast size parameter in StringRef constructor to size_t
aad86975 Fix get_x509_serial for long serial numbers
dc7a7df6 Adding CIFuzz
b3f85e2d Merge pull request openwrt#1444 from nghttp2/fix-recv-window-flow-control-issue
ffb49c6c Merge pull request openwrt#1435 from geoffhill/master
2ec58551 Fix receiving stream data stall
459df42b Merge pull request openwrt#1442 from nghttp2/upgrade-llhttp
a4c1fed5 Bump llhttp to 2.0.4
866eadb5 Enable session_create_idle_stream test, fix errors
5e13274b Fix typo
e0d7f7de h2load: Allow port in --connect-to
df575f96 h2load: add --connect-to option
1fff7379 clang-format-9
b40c6c86 Merge pull request openwrt#1418 from vszakats/patch-1
9bc2c75e lib/CMakeLists.txt: Make hard-coded static lib suffix optional
2d5f7659 Bump up version number to 1.41.0-DEV

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

Note this is cherry-pick from master. It fixes CVE-2020-11080
and  nxhack/openwrt-node-packages#679

Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
biliwala pushed a commit to biliwala/friendlywrt that referenced this issue Oct 16, 2020
@dedeckeh @biliwala
nghttp2: bump to 1.41.0
e588b53 
8f7b008b Update bash_completion
83086ba9 Update manual pages
c3b46625 Merge pull request from GHSA-q5wr-xfw9-q7xr
3eecc2ca Bump version number to v1.41.0, LT revision to 34:0:20
881c060d Update AUTHORS
f8da73bd Earlier check for settings flood
336a98fe Implement max settings option
ef415836 Revert "Add missing connection error handling"
979e6c53 Merge pull request openwrt#1459 from nghttp2/proxyprotov2
b7d16101 Add missing connection error handling
cd53bd81 Merge pull request openwrt#1460 from gportay/patch-1
e5625b8c Fix doc
c663349f integration: Add PROXY protocol v2 tests
854e9fe3 nghttpx: Always call init_forwarded_for
c60ea227 Update doc
49cd8e6 nghttpx: Add PROXY-protocol v2 support
3b17a659 Merge pull request openwrt#1453 from Leo-Neat/master
600fcdf5 Merge pull request openwrt#1455 from xjtian/long_serials
4922bb41 static_cast size parameter in StringRef constructor to size_t
aad86975 Fix get_x509_serial for long serial numbers
dc7a7df6 Adding CIFuzz
b3f85e2d Merge pull request openwrt#1444 from nghttp2/fix-recv-window-flow-control-issue
ffb49c6c Merge pull request openwrt#1435 from geoffhill/master
2ec58551 Fix receiving stream data stall
459df42b Merge pull request openwrt#1442 from nghttp2/upgrade-llhttp
a4c1fed5 Bump llhttp to 2.0.4
866eadb5 Enable session_create_idle_stream test, fix errors
5e13274b Fix typo
e0d7f7de h2load: Allow port in --connect-to
df575f96 h2load: add --connect-to option
1fff7379 clang-format-9
b40c6c86 Merge pull request openwrt#1418 from vszakats/patch-1
9bc2c75e lib/CMakeLists.txt: Make hard-coded static lib suffix optional
2d5f7659 Bump up version number to 1.41.0-DEV

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>

Note this is cherry-pick from master. It fixes CVE-2020-11080
and  nxhack/openwrt-node-packages#679

Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nxhack @BKPepe @sans-ltd