Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi brand / theme support on Style Dictionary config #70

Closed
1 task done
jgrodriguezc opened this issue Mar 28, 2023 · 2 comments · Fixed by #75
Closed
1 task done

Multi brand / theme support on Style Dictionary config #70

jgrodriguezc opened this issue Mar 28, 2023 · 2 comments · Fixed by #75
Assignees
@sebastiandg7
Labels
enhancement New feature or request

Comments

@jgrodriguezc
Copy link
Contributor

Is your feature request related to a problem?

No

Describe the solution or feature you'd like

I'd like to have the possibility to add multiple configurations depends on brand or theme that i am build.

Describe alternatives you've considered

I found this example from Style Dictionary oficial repository, you could have something similar using an array of configuration instead of only one configuration object in style-dictionary.config.ts.

Later you could use that array of configuration to build something similar to the example.

Additional context

This is a feature that i need to build different folders depending on which brand and theme those tokens belong.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jgrodriguezc jgrodriguezc added the enhancement New feature or request label Mar 28, 2023
@sebastiandg7 sebastiandg7 self-assigned this Mar 28, 2023
@sebastiandg7
Copy link
Member

@allcontributors please add @jgrodriguezc for ideas

@allcontributors allcontributors bot mentioned this issue Mar 28, 2023
Merged
@allcontributors
Copy link
Contributor

@sebastiandg7

I've put up a pull request to add @jgrodriguezc! 🎉

@sebastiandg7 sebastiandg7 mentioned this issue Mar 28, 2023
Closed
1 task
jgrodriguezc added a commit to jgrodriguezc/nxkit that referenced this issue Mar 29, 2023
@jgrodriguezc
feat(style-dictionary): multi config support added
539823c 
ISSUES CLOSED: nxkit#70
jgrodriguezc added a commit to jgrodriguezc/nxkit that referenced this issue Mar 31, 2023
@jgrodriguezc
feat(style-dictionary): single and multi config support added
243468b 
ISSUES CLOSED: nxkit#70
jgrodriguezc added a commit to jgrodriguezc/nxkit that referenced this issue Mar 31, 2023
@jgrodriguezc
feat(style-dictionary): tests and new preset added to multi config fe…
4995b8b 
…ature

ISSUES CLOSED: nxkit#70
@jgrodriguezc jgrodriguezc mentioned this issue Mar 31, 2023
Merged
3 tasks
@sebastiandg7 sebastiandg7 reopened this Apr 19, 2023
sebastiandg7 pushed a commit that referenced this issue Apr 25, 2023
@jgrodriguezc
feat(style-dictionary): multi config support (#75)
6a95422 
* feat(style-dictionary): multi config support added

ISSUES CLOSED: #70

* feat(style-dictionary): single and multi config support added

ISSUES CLOSED: #70

* feat(style-dictionary): tests and new preset added to multi config feature

ISSUES CLOSED: #70

* style dictionary package name changed

* Revert "style dictionary package name changed"

This reverts commit 3e111d7.

* fix(style-dictionary): include prop support fixed and runBuild improvememt on extensions registry

* cleanup(style-dictionary): style dictionary test name changes

* cleanup(style-dictionary): tests name changes

* cleanup(style-dictionary): format fixed

* cleanup(style-dictionary): config names changed to prural
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastiandg7 sebastiandg7

Labels
enhancement New feature or request
Projects
NxKit tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/style dictionary/multi config support jgrodriguezc/nxkit
2 participants
@sebastiandg7 @jgrodriguezc