src: add --chip_0_size param #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --chip_0_size param to override the size of the mtd partition which is required if the SPL does not occupy the entire partition. For Gateworks Ventana boards the 'uboot' partition contains both the SPL and uboot. Signed-off-by: Tim Harvey <tharvey@gateworks.com> Signed-off-by: Pushpal Sidhu <psidhu@gateworks.com>
agners
reviewed
Sep 20, 2017
| if (md->cfg.chip_0_size) { | ||
| miu->size = md->cfg.chip_0_size; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this will apply for chip 0 and 1. It should be rather easy to actually make it chip 0/1 compatible, just check for i as it is done above with chip_[0|1]_device_path, e.g.
if (i == 0 && md->cfg.chip_0_size)
miu->size = md->cfg.chip_0_size;
else if (i == 1 && md->cfg.chip_1_size)
miu->size = md->cfg.chip_1_size;
|
On Wed, Sep 20, 2017 at 9:09 AM, Stefan Agner ***@***.***> wrote:
@falstaff84 commented on this pull request.
________________________________
In src/mtd.c:
> @@ -889,6 +889,11 @@ struct mtd_data *mtd_open(const struct mtd_config *cfg, int flags)
goto out;
}
+ /* override MTD size */
+ if (md->cfg.chip_0_size) {
+ miu->size = md->cfg.chip_0_size;
+ }
+
I think this will apply for chip 0 and 1. It should be rather easy to actually make it chip 0/1 compatible, just check for i as it is done above with chip_[0|1]_device_path, e.g.
if (i == 0 && md->cfg.chip_0_size)
miu->size = md->cfg.chip_0_size;
else if (i == 1 && md->cfg.chip_1_size)
miu->size = md->cfg.chip_1_size;
Sounds reasonable to me. I don't have any multi-chip boards to test with.
Tim
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --chip_0_size param to override the size of the mtd partition which is
required if the SPL does not occupy the entire partition. For Gateworks
Ventana boards the 'uboot' partition contains both the SPL and uboot.
Signed-off-by: Tim Harvey tharvey@gateworks.com
Signed-off-by: Pushpal Sidhu psidhu@gateworks.com