Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests mistakenly 'succeed' when exceptions are thrown #5

Open
crispinb opened this issue Aug 2, 2013 · 3 comments
Open

Tests mistakenly 'succeed' when exceptions are thrown #5

crispinb opened this issue Aug 2, 2013 · 3 comments

Comments

@crispinb
Copy link

crispinb commented Aug 2, 2013

If an exception is raised during a test run, the test stops prematurely, as expected, but is reported by SenTestingKitAsync as a Success. This is a regression from the stock SenTestingKit, which fails tests when exceptions are raised.
@dpassage
Copy link

dpassage commented Aug 2, 2013

@crispinb In my project, I'm seeing that the log message reports the failure, but Xcode thinks the run was successful. Is that what you're seeing?

@crispinb
Copy link
Author

crispinb commented Aug 2, 2013

@dpassage Exactly (sorry, should have pointed that out). Same in AppCode. I don't know anything about how SenTestKit communicates with the test runner, but the stock behaviour is clearly preferable.

gregschlom added a commit to gregschlom/SenTestingKitAsync that referenced this issue Nov 11, 2013
@gregschlom
Fix issue nxtbgthng#5 - tests were reporting success if an exception …
b3cb1be 
…was being thrown
@gregschlom
Copy link

@dpassage @crispinb I have a pull request here to fix this issue, if you guys are still interested: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregschlom @dpassage @crispinb