Skip to content

Commit

Permalink
lib: un microtasks before ticks
Browse files Browse the repository at this point in the history
This resolve multiple timing issues related to promises
and nextTick. As well as resolving zaldo in promise only
code, i.e. our current best practice of using process.nextTick
will always apply and work.

Refs: nodejs#51156
Refs: nodejs#51156 (comment)
Refs: nodejs#51114
Refs: nodejs#51070
Refs: nodejs#51156

PR-URL: nodejs#51267
  • Loading branch information
ronag committed Dec 24, 2023
1 parent fc102f2 commit 17de9ba
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion lib/internal/process/task_queues.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,14 @@ const {
symbols: { async_id_symbol, trigger_async_id_symbol },
} = require('internal/async_hooks');
const FixedQueue = require('internal/fixed_queue');
const { getOptionValue } = require('internal/options');

const {
validateFunction,
} = require('internal/validators');

const experimentalTaskOrdering = getOptionValue('--experimental-task-ordering');

const { AsyncResource } = require('async_hooks');

// *Must* match Environment::TickInfo::Fields in src/env.h.
Expand Down Expand Up @@ -67,6 +70,9 @@ function runNextTicks() {
function processTicksAndRejections() {
let tock;
do {
if (experimentalTaskOrdering) {
runMicrotasks();
}
while ((tock = queue.shift()) !== null) {
const asyncId = tock[async_id_symbol];
emitBefore(asyncId, tock[trigger_async_id_symbol], tock);
Expand All @@ -92,7 +98,9 @@ function processTicksAndRejections() {

emitAfter(asyncId);
}
runMicrotasks();
if (!experimentalTaskOrdering) {
runMicrotasks();
}
} while (!queue.isEmpty() || processPromiseRejections());
setHasTickScheduled(false);
setHasRejectionToWarn(false);
Expand Down

0 comments on commit 17de9ba

Please sign in to comment.