Fix processing Execute SQL algorithms steal ownership of database pro…

…viders Fixes qgis#36641
nyalldawson · May 22, 2020 · 288ba2e · 288ba2e
1 parent 25e24e7
commit 288ba2e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/analysis/processing/qgsalgorithmexecutepostgisquery.cpp b/src/analysis/processing/qgsalgorithmexecutepostgisquery.cpp
@@ -72,7 +72,7 @@ QVariantMap QgsExecutePostgisQueryAlgorithm::processAlgorithm( const QVariantMap
   std::unique_ptr<QgsAbstractDatabaseProviderConnection> conn;
   try
   {
-    std::unique_ptr<QgsProviderMetadata> md( QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "postgres" ) ) );
+    QgsProviderMetadata *md = QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "postgres" ) );
     conn.reset( static_cast<QgsAbstractDatabaseProviderConnection *>( md->createConnection( connName ) ) );
   }
   catch ( QgsProviderConnectionException & )

diff --git a/src/analysis/processing/qgsalgorithmexecutespatialitequery.cpp b/src/analysis/processing/qgsalgorithmexecutespatialitequery.cpp
@@ -83,7 +83,7 @@ QVariantMap QgsExecuteSpatialiteQueryAlgorithm::processAlgorithm( const QVariant
   std::unique_ptr<QgsAbstractDatabaseProviderConnection> conn;
   try
   {
-    std::unique_ptr<QgsProviderMetadata> md( QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "spatialite" ) ) );
+    QgsProviderMetadata *md = QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "spatialite" ) );
     conn.reset( static_cast<QgsAbstractDatabaseProviderConnection *>( md->createConnection( uri.uri(), QVariantMap() ) ) );
   }
   catch ( QgsProviderConnectionException & )

diff --git a/src/analysis/processing/qgsalgorithmexecutespatialitequeryregistered.cpp b/src/analysis/processing/qgsalgorithmexecutespatialitequeryregistered.cpp
@@ -72,7 +72,7 @@ QVariantMap QgsExecuteRegisteredSpatialiteQueryAlgorithm::processAlgorithm( cons
   std::unique_ptr<QgsAbstractDatabaseProviderConnection> conn;
   try
   {
-    std::unique_ptr<QgsProviderMetadata> md( QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "spatialite" ) ) );
+    QgsProviderMetadata *md = QgsProviderRegistry::instance()->providerMetadata( QStringLiteral( "spatialite" ) );
     conn.reset( static_cast<QgsAbstractDatabaseProviderConnection *>( md->createConnection( connName ) ) );
   }
   catch ( QgsProviderConnectionException & )