Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R console changes #25

Merged
merged 4 commits into from Oct 4, 2022
Merged

Conversation

JanCaha
Copy link

@JanCaha JanCaha commented Oct 4, 2022

Handles printing of objects by R means, which means that expressions are evaluated in the same way as in R command line or RStudio. Makes it very easy to print even data.frames. Test by inputing mtcars into console.

The QgsRStatsSession::execCommand only returns valid value if the SEXP is of length 1, otherwise it returns empty QVariant() for now, to avoid errors in the console output.Possibly QList of values should be returned for R vectors?

@nyalldawson nyalldawson merged commit 4056855 into nyalldawson:r_console Oct 4, 2022
@nyalldawson
Copy link
Owner

Thanks @JanCaha , looks great!!

Possibly QList of values should be returned for R vectors?

That's what I'm thinking. We could use a QVariantList here and recursively convert each individual element...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants