forked from shaka-project/shaka-player
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Fix thumbnail duration, expose start time and duration
Thumbnail segments may be structured for a certain grid size and duration, but the segment references may have their duration truncated due to the end of a period or the end of the presentation. This was causing us to calculate the wrong duration for those individual thumbnails, and therefore return the wrong thumbnail. We also did not have any way to indicate to an application how long a thumbnail should be shown. This fixes the duration calculation by retaining the original, untruncated duration in SegmentReference. This also exposes startTime and duration information on the Thumbnail object, so that applications know when/where and how long to show a given thumbnail. Closes shaka-project#3517 Change-Id: I84aa7705a19691fc6ae68eee9944fecbd7067fe0
- Loading branch information
1 parent
84b9a89
commit d4a1255
Showing
7 changed files
with
80 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters