This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Node parsing should always treat native django tags as plain text #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t try to parse %} as element
2 similar comments
nicpottier
suggested changes
Dec 13, 2016
|
|
||
| if stream.text[stream.ptr] in ELEMENT_PREFIXES and not is_variable: | ||
| # peek ahead to so we don't try to parse an element from a variable node starting #{ or a Django tag ending %} | ||
| if stream.text[stream.ptr] in ELEMENT_PREFIXES and stream.text[stream.ptr:stream.ptr+2] not in ('#{', '%}'): |
There was a problem hiding this comment.
Any possibility of indexing out of bounds here?
There was a problem hiding this comment.
It's a slice so if it's out of bounds it will just return ''
| @@ -129,6 +132,10 @@ def test_plain_text(self): | |||
| self._test("This should be plain text\n This should be indented", | |||
| "This should be plain text\n This should be indented") | |||
|
|
|||
| # native Django tags {% %} should be treated as plain text | |||
| self._test("text {%\n trans ''\n%}", "text {%\n trans ''\n%}") | |||
| self._test("text\n {%\n trans ''\n%}", "text\n {%\n trans ''\n%}") | |||
There was a problem hiding this comment.
Does it make sense to have a test that starts the Django node at an indent? IE:
.blarg
This is text
{% trans
"hello world
%}There was a problem hiding this comment.
Oh I guess looking at this more closely the second is very close to this..
nicpottier
approved these changes
Dec 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. don't try to parse %} as an element. This addresses #45