This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Attribute dictionary tweaks #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpottier
reviewed
Mar 13, 2017
| self._test('%form(foo=bar id="myform")', "<form foo='{{ bar }}' id='myform'></form>") | ||
|
|
||
| # multiple dicts | ||
| self._test('%a(a="b"){:c => "d"} Stuff', "<a a='b' c='d'>Stuff</a>") |
There was a problem hiding this comment.
I can think of no good use for it but also no reason to not support it since it's in the spec.. no?
|
@nicpottier have made few additional changes so please take another look |
…r parsing attribute values which are Haml
rowanseymour
commented
Mar 14, 2017
| if value is None: | ||
| rendered.append("%s" % name) # boolean attribute | ||
| if name in ('id', 'class') or value in (None, False): | ||
| # this line isn't recorded in coverage because it gets optimized away (http://bugs.python.org/issue2506) |
There was a problem hiding this comment.
@nicpottier @ericnewcomer @norkans7 just in case anyone runs into something similar - a line which is definitely hit, but not included in coverage because CPython optimizes it away.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.(foo=bar)is compiled to<div foo="{{ bar }}"></div>%a(title=@title){:href => @link.href} Stuff.(foo=True)as a boolean attribute, and.(foo=None)as removing attributefoochecked="checked"in XHTML mode