Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUT option #125

Merged
merged 3 commits into from
Jan 31, 2018
Merged

PUT option #125

merged 3 commits into from
Jan 31, 2018

Conversation

ycleptkellan
Copy link
Contributor

  • refactors WebhookRouter to appease tslint
  • adds Methods enum
  • adds PUT option

@ericnewcomer
Copy link
Member

Can't add it to the editor without also adding an issue for it on goflow

@ycleptkellan
Copy link
Contributor Author

doh will do

@ycleptkellan
Copy link
Contributor Author

Do you think the Methods enum is enough validation for now?

nyaruka/goflow#143

@ericnewcomer
Copy link
Member

Ya, as long as it's restricted to the set we want, I think we are good here.

@ycleptkellan ycleptkellan force-pushed the put-option branch 2 times, most recently from 6b3af32 to f77f2b2 Compare January 31, 2018 02:25
@ericnewcomer ericnewcomer merged commit 86e44b3 into master Jan 31, 2018
@ericnewcomer ericnewcomer deleted the put-option branch January 31, 2018 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnewcomer ericnewcomer ericnewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ycleptkellan @ericnewcomer