Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚶 Offline flow tweaks #425

Merged
merged 7 commits into from
Oct 22, 2018
Merged

🚶 Offline flow tweaks #425

merged 7 commits into from
Oct 22, 2018

Conversation

rowanseymour
Copy link
Member

  • Change send_msg to always send a message even if it can't resolve channel/URN
  • Validate flow types

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #425 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   66.76%   66.78%   +0.02%     
==========================================
  Files         157      157              
  Lines        8277     8282       +5     
==========================================
+ Hits         5526     5531       +5     
  Misses       2382     2382              
  Partials      369      369
Impacted Files Coverage Δ
cmd/flowrunner/main.go 46.59% <ø> (ø) ⬆️
flows/msg.go 18.51% <ø> (ø) ⬆️
flows/actions/send_msg.go 100% <100%> (ø) ⬆️
flows/definition/flow.go 70.58% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03af3a...56da0cf. Read the comment docs.

@rowanseymour rowanseymour merged commit a3c21a0 into master Oct 22, 2018
@rowanseymour rowanseymour deleted the offline branch March 28, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant