Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase non-overlap on timeout queueing, never double queue #1097

Merged
merged 2 commits into from Feb 13, 2017
Merged

Increase non-overlap on timeout queueing, never double queue #1097

merged 2 commits into from Feb 13, 2017

Conversation

nicpottier
Copy link
Collaborator

When we are timing out a huge number of runs we can double queue the handling of those and get in a giant loop.

Two changes:

  • task grabs a lock for 1 hour instead of 15 mins
  • we keep track of run/timeout pairs we have queued to process and never double queue

Should keep us from getting too out of control.

ericnewcomer
ericnewcomer approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@ericnewcomer ericnewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@nicpottier nicpottier merged commit 3295c01 into master Feb 13, 2017
@nicpottier nicpottier deleted the prevent-double-timeouts branch February 13, 2017 22:10
@nicpottier nicpottier removed the review label Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnewcomer ericnewcomer ericnewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicpottier @ericnewcomer