Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⛈️ Make Contact.modified_by nullable and stop writing to it #2136

Merged
merged 2 commits into from
Oct 1, 2018
Merged

⛈️ Make Contact.modified_by nullable and stop writing to it #2136

merged 2 commits into from
Oct 1, 2018

Conversation

rowanseymour
Copy link
Member

This might speed up writes to contacts because we won't be locking on the user table

@dodobas dodobas added the review label Sep 28, 2018
@rowanseymour rowanseymour merged commit 38678eb into master Oct 1, 2018
@dodobas dodobas removed the review label Oct 1, 2018
@rowanseymour rowanseymour deleted the remove_contact_modified_by branch October 1, 2018 14:27
@rowanseymour rowanseymour mentioned this pull request Oct 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkans7 norkans7 norkans7 approved these changes

@ericnewcomer ericnewcomer Awaiting requested review from ericnewcomer

@nicpottier nicpottier Awaiting requested review from nicpottier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rowanseymour @norkans7 @dodobas