Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0️⃣ Make ChannelConnection.is_active nullable so it can be eventually removed #2286

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

rowanseymour
Copy link
Member

Was about to remove ChannelConnection.created_by and noticed we also never use this - connections like sessions are hard deleted. So we can 1) make it nullable 2) stop setting it in mailroom 3) remove it

Copy link
Collaborator

@nicpottier nicpottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man the scourge of smart models sure has deep tendrils

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #2286 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2286   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         221     221           
  Lines       26344   26344           
======================================
  Hits        26344   26344
Impacted Files Coverage Δ
temba/ivr/tasks.py 100% <ø> (ø) ⬆️
temba/channels/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e6e8e...f211fcc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants