馃搮 Add Last Seen On as a system field so it can be used in campaigns #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Aug 11, 2020
| KEY_NAME: dict(label="Name", value_type=Value.TYPE_TEXT), | ||
| KEY_CREATED_ON: dict(label="Created On", value_type=Value.TYPE_DATETIME), | ||
| KEY_LANGUAGE: dict(label="Language", value_type=Value.TYPE_TEXT), | ||
| KEY_LAST_SEEN_ON: dict(label="Last Seen On", value_type=Value.TYPE_DATETIME), |
There was a problem hiding this comment.
I don't think these labels are supposed to be localized in the DB.. we could find a way to localize them in the UI.. tho even that could get confusing since Name will be always be name in expressions etc
rowanseymour
commented
Aug 11, 2020
| @@ -1094,45 +1094,6 @@ def create_welcome_topup(self, topup_size=None): | |||
| return TopUp.create(self.created_by, price=0, credits=topup_size, org=self) | |||
| return None | |||
|
|
|||
| def create_system_groups(self): | |||
There was a problem hiding this comment.
just a little bit of dependency re-arranging - Org shouldn't need to know how fields and groups are created
Codecov Report
@@ Coverage Diff @@
## master #2902 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 378 379 +1
Lines 25429 25441 +12
=========================================
+ Hits 25429 25441 +12
Continue to review full report at Codecov.
|
norkans7
approved these changes
Aug 12, 2020
nicpottier
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.