Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pocket items not opening in browser #32

Closed
oldjove opened this issue Aug 9, 2021 · 7 comments · Fixed by #35
Closed

Pocket items not opening in browser #32

oldjove opened this issue Aug 9, 2021 · 7 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@oldjove
Copy link

oldjove commented Aug 9, 2021

Hi, very excited about this app. Looks like it will be great for my workflow. However, at the moment when I CRTL+click on an item in the Pocket list, the appropriate note is created, but the webpage doesn't load in Firefox and I get this error message: "You'll need a new app to open this app."

Any idea what might be going wrong?

@oldjove
Copy link
Author

oldjove commented Aug 9, 2021

Actually, this also happens when I normal click.

@thecookiemomma
Copy link

thecookiemomma commented Aug 10, 2021

Me too. Neither clicking nor ctrl+clicking on the links works. I believe for Windows, the link needs to be obsidian://name for the click and regular http:// for the ctrl+click. I may be wrong, though. I did want to add that this is pretty exciting for me as well as it serves to do what I was wanting, which was a way to collate and notate items on the web through obsidian. Well done!

@nybbles nybbles added the bug Something isn't working label Aug 10, 2021
@nybbles
Copy link
Owner

nybbles commented Aug 10, 2021

@oldjove and @thecookiemomma, thanks for the bug report. Are you both on Windows? and this happens for all Pocket entries?

@oldjove
Copy link
Author

oldjove commented Aug 11, 2021

@nybbles Yep, I'm on Windows 10. It seems to happen for all entries. At least I haven't noticed any exceptions.

@nybbles
Copy link
Owner

nybbles commented Aug 11, 2021

Hello @oldjove and @thecookiemomma, the problem you encountered should be fixed now, if you upgrade to https://github.com/nybbles/obsidian-pocket/releases/tag/0.3.2 via the Obsidian app.

You might still not be able to create a note for a Pocket item if you specify invalid paths (under plugin settings) for Pocket item note template file location and Pocket item notes folder location, but you will see a clear error message. If you leave those settings blank, they will use defaults (i.e. a blank template, and notes for Pocket items found and stored in the root folder).

I also switched the Windows modifier key to open the URL to Alt, rather than Meta, because it seemed as though on Windows the Meta key just is globally bound to open the start menu. I'm not a Windows user, so I missed that.

Please LMK if you have any further issues (i.e. re-open this one if it remains unsolved, or open a new one if you spot something else). Thanks for your bug report!

@thecookiemomma
Copy link

Looks like the alt click works, as does putting the correct folder in the correct setting. Thank you for the prompt fix! This will help a lot!

@oldjove
Copy link
Author

oldjove commented Aug 12, 2021

Thanks @nybbles ! Seems to work like a treat now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants